Эх сурвалжийг харах

pinctrl: lpc18xx: fix schmitt trigger setup

The param_val variable is what determines if schmitt
trigger is enabled on a pin or not. A typo here mean
that schmitt trigger was always enabled for standard
and i2c pins.

Signed-off-by: Joachim Eastwood <manabian@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Joachim Eastwood 10 жил өмнө
parent
commit
681ccdcc75

+ 2 - 2
drivers/pinctrl/pinctrl-lpc18xx.c

@@ -823,7 +823,7 @@ static int lpc18xx_pconf_set_i2c0(struct pinctrl_dev *pctldev,
 		break;
 		break;
 
 
 	case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
 	case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
-		if (param)
+		if (param_val)
 			*reg &= ~(LPC18XX_SCU_I2C0_ZIF << shift);
 			*reg &= ~(LPC18XX_SCU_I2C0_ZIF << shift);
 		else
 		else
 			*reg |= (LPC18XX_SCU_I2C0_ZIF << shift);
 			*reg |= (LPC18XX_SCU_I2C0_ZIF << shift);
@@ -876,7 +876,7 @@ static int lpc18xx_pconf_set_pin(struct pinctrl_dev *pctldev,
 		break;
 		break;
 
 
 	case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
 	case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
-		if (param)
+		if (param_val)
 			*reg &= ~LPC18XX_SCU_PIN_ZIF;
 			*reg &= ~LPC18XX_SCU_PIN_ZIF;
 		else
 		else
 			*reg |= LPC18XX_SCU_PIN_ZIF;
 			*reg |= LPC18XX_SCU_PIN_ZIF;