Browse Source

HID: wacom: Delete unnecessary checks before the function call "input_free_device"

The input_free_device() function tests whether its argument is NULL and
then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Markus Elfring 10 years ago
parent
commit
67e123ff0e
1 changed files with 3 additions and 6 deletions
  1. 3 6
      drivers/hid/wacom_sys.c

+ 3 - 6
drivers/hid/wacom_sys.c

@@ -1149,12 +1149,9 @@ static void wacom_free_inputs(struct wacom *wacom)
 {
 {
 	struct wacom_wac *wacom_wac = &(wacom->wacom_wac);
 	struct wacom_wac *wacom_wac = &(wacom->wacom_wac);
 
 
-	if (wacom_wac->pen_input)
-		input_free_device(wacom_wac->pen_input);
-	if (wacom_wac->touch_input)
-		input_free_device(wacom_wac->touch_input);
-	if (wacom_wac->pad_input)
-		input_free_device(wacom_wac->pad_input);
+	input_free_device(wacom_wac->pen_input);
+	input_free_device(wacom_wac->touch_input);
+	input_free_device(wacom_wac->pad_input);
 	wacom_wac->pen_input = NULL;
 	wacom_wac->pen_input = NULL;
 	wacom_wac->touch_input = NULL;
 	wacom_wac->touch_input = NULL;
 	wacom_wac->pad_input = NULL;
 	wacom_wac->pad_input = NULL;