浏览代码

x86/entry/64: Add two more instruction suffixes

Sadly, other than claimed in:

  a368d7fd2a ("x86/entry/64: Add instruction suffix")

... there are two more instances which want to be adjusted.

As said there, omitting suffixes from instructions in AT&T mode is bad
practice when operand size cannot be determined by the assembler from
register operands, and is likely going to be warned about by upstream
gas in the future (mine does already).

Add the other missing suffixes here as well.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/5B3A02DD02000078001CFB78@prv1-mh.provo.novell.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Jan Beulich 7 年之前
父节点
当前提交
6709812f09
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      arch/x86/entry/entry_64.S

+ 2 - 2
arch/x86/entry/entry_64.S

@@ -92,7 +92,7 @@ END(native_usergs_sysret64)
 .endm
 .endm
 
 
 .macro TRACE_IRQS_IRETQ_DEBUG
 .macro TRACE_IRQS_IRETQ_DEBUG
-	bt	$9, EFLAGS(%rsp)		/* interrupts off? */
+	btl	$9, EFLAGS(%rsp)		/* interrupts off? */
 	jnc	1f
 	jnc	1f
 	TRACE_IRQS_ON_DEBUG
 	TRACE_IRQS_ON_DEBUG
 1:
 1:
@@ -702,7 +702,7 @@ retint_kernel:
 #ifdef CONFIG_PREEMPT
 #ifdef CONFIG_PREEMPT
 	/* Interrupts are off */
 	/* Interrupts are off */
 	/* Check if we need preemption */
 	/* Check if we need preemption */
-	bt	$9, EFLAGS(%rsp)		/* were interrupts off? */
+	btl	$9, EFLAGS(%rsp)		/* were interrupts off? */
 	jnc	1f
 	jnc	1f
 0:	cmpl	$0, PER_CPU_VAR(__preempt_count)
 0:	cmpl	$0, PER_CPU_VAR(__preempt_count)
 	jnz	1f
 	jnz	1f