浏览代码

pNFS/flexfiles: missing error code in ff_layout_alloc_lseg()

If xdr_inline_decode() fails then we end up returning ERR_PTR(0).  The
caller treats NULL returns as -ENOMEM so it doesn't really hurt runtime,
but obviously we intended to set an error code here.

Fixes: d67ae825a59d ("pnfs/flexfiles: Add the FlexFile Layout Driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Dan Carpenter 8 年之前
父节点
当前提交
662f9a105b
共有 1 个文件被更改,包括 1 次插入0 次删除
  1. 1 0
      fs/nfs/flexfilelayout/flexfilelayout.c

+ 1 - 0
fs/nfs/flexfilelayout/flexfilelayout.c

@@ -454,6 +454,7 @@ ff_layout_alloc_lseg(struct pnfs_layout_hdr *lh,
 			goto out_err_free;
 
 		/* fh */
+		rc = -EIO;
 		p = xdr_inline_decode(&stream, 4);
 		if (!p)
 			goto out_err_free;