Browse Source

ASoC: omap-mcpdm: Add support for pdmclk clock handling

McPDM module receives it's functional clock from external source. This
clock is the pdmclk provided by the twl6040 audio IC. If the clock is not
available all register accesses to McPDM fails and the module is not
operational.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Peter Ujfalusi 9 years ago
parent
commit
65aca64d05

+ 10 - 0
Documentation/devicetree/bindings/sound/omap-mcpdm.txt

@@ -8,6 +8,8 @@ Required properties:
 - interrupts: Interrupt number for McPDM
 - interrupts: Interrupt number for McPDM
 - interrupt-parent: The parent interrupt controller
 - interrupt-parent: The parent interrupt controller
 - ti,hwmods: Name of the hwmod associated to the McPDM
 - ti,hwmods: Name of the hwmod associated to the McPDM
+- clocks:  phandle for the pdmclk provider, likely <&twl6040>
+- clock-names: Must be "pdmclk"
 
 
 Example:
 Example:
 
 
@@ -19,3 +21,11 @@ mcpdm: mcpdm@40132000 {
 	interrupt-parent = <&gic>;
 	interrupt-parent = <&gic>;
 	ti,hwmods = "mcpdm";
 	ti,hwmods = "mcpdm";
 };
 };
+
+In board DTS file the pdmclk needs to be added:
+
+&mcpdm {
+	clocks = <&twl6040>;
+	clock-names = "pdmclk";
+	status = "okay";
+};

+ 17 - 0
sound/soc/omap/omap-mcpdm.c

@@ -31,6 +31,7 @@
 #include <linux/err.h>
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/io.h>
 #include <linux/irq.h>
 #include <linux/irq.h>
+#include <linux/clk.h>
 #include <linux/slab.h>
 #include <linux/slab.h>
 #include <linux/pm_runtime.h>
 #include <linux/pm_runtime.h>
 #include <linux/of_device.h>
 #include <linux/of_device.h>
@@ -54,6 +55,7 @@ struct omap_mcpdm {
 	unsigned long phys_base;
 	unsigned long phys_base;
 	void __iomem *io_base;
 	void __iomem *io_base;
 	int irq;
 	int irq;
+	struct clk *pdmclk;
 
 
 	struct mutex mutex;
 	struct mutex mutex;
 
 
@@ -388,6 +390,7 @@ static int omap_mcpdm_probe(struct snd_soc_dai *dai)
 	struct omap_mcpdm *mcpdm = snd_soc_dai_get_drvdata(dai);
 	struct omap_mcpdm *mcpdm = snd_soc_dai_get_drvdata(dai);
 	int ret;
 	int ret;
 
 
+	clk_prepare_enable(mcpdm->pdmclk);
 	pm_runtime_enable(mcpdm->dev);
 	pm_runtime_enable(mcpdm->dev);
 
 
 	/* Disable lines while request is ongoing */
 	/* Disable lines while request is ongoing */
@@ -422,6 +425,7 @@ static int omap_mcpdm_remove(struct snd_soc_dai *dai)
 
 
 	pm_runtime_disable(mcpdm->dev);
 	pm_runtime_disable(mcpdm->dev);
 
 
+	clk_disable_unprepare(mcpdm->pdmclk);
 	return 0;
 	return 0;
 }
 }
 
 
@@ -441,6 +445,8 @@ static int omap_mcpdm_suspend(struct snd_soc_dai *dai)
 		mcpdm->pm_active_count++;
 		mcpdm->pm_active_count++;
 	}
 	}
 
 
+	clk_disable_unprepare(mcpdm->pdmclk);
+
 	return 0;
 	return 0;
 }
 }
 
 
@@ -448,6 +454,8 @@ static int omap_mcpdm_resume(struct snd_soc_dai *dai)
 {
 {
 	struct omap_mcpdm *mcpdm = snd_soc_dai_get_drvdata(dai);
 	struct omap_mcpdm *mcpdm = snd_soc_dai_get_drvdata(dai);
 
 
+	clk_prepare_enable(mcpdm->pdmclk);
+
 	if (mcpdm->pm_active_count) {
 	if (mcpdm->pm_active_count) {
 		while (mcpdm->pm_active_count--)
 		while (mcpdm->pm_active_count--)
 			pm_runtime_get_sync(mcpdm->dev);
 			pm_runtime_get_sync(mcpdm->dev);
@@ -541,6 +549,15 @@ static int asoc_mcpdm_probe(struct platform_device *pdev)
 
 
 	mcpdm->dev = &pdev->dev;
 	mcpdm->dev = &pdev->dev;
 
 
+	mcpdm->pdmclk = devm_clk_get(&pdev->dev, "pdmclk");
+	if (IS_ERR(mcpdm->pdmclk)) {
+		if (PTR_ERR(mcpdm->pdmclk) == -EPROBE_DEFER)
+			return -EPROBE_DEFER;
+		dev_warn(&pdev->dev, "Error getting pdmclk (%ld)!\n",
+			 PTR_ERR(mcpdm->pdmclk));
+		mcpdm->pdmclk = NULL;
+	}
+
 	ret =  devm_snd_soc_register_component(&pdev->dev,
 	ret =  devm_snd_soc_register_component(&pdev->dev,
 					       &omap_mcpdm_component,
 					       &omap_mcpdm_component,
 					       &omap_mcpdm_dai, 1);
 					       &omap_mcpdm_dai, 1);