Эх сурвалжийг харах

jfs: Deletion of an unnecessary check before the function call "unload_nls"

The unload_nls() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Markus Elfring 10 жил өмнө
parent
commit
648695c748
1 өөрчлөгдсөн 1 нэмэгдсэн , 2 устгасан
  1. 1 2
      fs/jfs/super.c

+ 1 - 2
fs/jfs/super.c

@@ -619,8 +619,7 @@ out_mount_failed:
 	iput(sbi->direct_inode);
 	iput(sbi->direct_inode);
 	sbi->direct_inode = NULL;
 	sbi->direct_inode = NULL;
 out_unload:
 out_unload:
-	if (sbi->nls_tab)
-		unload_nls(sbi->nls_tab);
+	unload_nls(sbi->nls_tab);
 out_kfree:
 out_kfree:
 	kfree(sbi);
 	kfree(sbi);
 	return ret;
 	return ret;