Browse Source

net: phy: Fix return value check in xgmiitorgmii_probe()

In case of error, the function of_parse_phandle() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Wei Yongjun 9 years ago
parent
commit
64721094b9
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/net/phy/xilinx_gmii2rgmii.c

+ 1 - 1
drivers/net/phy/xilinx_gmii2rgmii.c

@@ -67,7 +67,7 @@ int xgmiitorgmii_probe(struct mdio_device *mdiodev)
 		return -ENOMEM;
 		return -ENOMEM;
 
 
 	phy_node = of_parse_phandle(np, "phy-handle", 0);
 	phy_node = of_parse_phandle(np, "phy-handle", 0);
-	if (IS_ERR(phy_node)) {
+	if (!phy_node) {
 		dev_err(dev, "Couldn't parse phy-handle\n");
 		dev_err(dev, "Couldn't parse phy-handle\n");
 		return -ENODEV;
 		return -ENODEV;
 	}
 	}