浏览代码

char/tpm/tpm_i2c_stm_st33: Don't use memcpy for one byte assignment

We don't need to call memcpy for one byte, but assign it directly.
And to make the offset clearer we use the array syntax on the subsequent
call to memset to make the relationship clearer.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Kent Yoder <key@linux.vnet.ibm.com>
Peter Huewe 12 年之前
父节点
当前提交
64298919ad
共有 1 个文件被更改,包括 2 次插入4 次删除
  1. 2 4
      drivers/char/tpm/tpm_i2c_stm_st33.c

+ 2 - 4
drivers/char/tpm/tpm_i2c_stm_st33.c

@@ -96,15 +96,13 @@ enum tis_defaults {
 static int write8_reg(struct i2c_client *client, u8 tpm_register,
 		      u8 *tpm_data, u16 tpm_size)
 {
-	u8 data;
 	int value = 0;
 	struct st33zp24_platform_data *pin_infos;
 
 	pin_infos = client->dev.platform_data;
 
-	data = tpm_register;
-	memcpy(pin_infos->tpm_i2c_buffer[0], &data, sizeof(data));
-	memcpy(pin_infos->tpm_i2c_buffer[0] + 1, tpm_data, tpm_size);
+	pin_infos->tpm_i2c_buffer[0][0] = tpm_register;
+	memcpy(&pin_infos->tpm_i2c_buffer[0][1], tpm_data, tpm_size);
 	value = i2c_master_send(client, pin_infos->tpm_i2c_buffer[0],
 				tpm_size + 1);
 	return value;