瀏覽代碼

net: caif: Add a missing rcu_read_unlock() in caif_flow_cb

Add a missing rcu_read_unlock in the error path

Fixes: c95567c80352 ("caif: added check for potential null return")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
YueHaibing 7 年之前
父節點
當前提交
64119e05f7
共有 1 個文件被更改,包括 3 次插入1 次删除
  1. 3 1
      net/caif/caif_dev.c

+ 3 - 1
net/caif/caif_dev.c

@@ -131,8 +131,10 @@ static void caif_flow_cb(struct sk_buff *skb)
 	caifd = caif_get(skb->dev);
 	caifd = caif_get(skb->dev);
 
 
 	WARN_ON(caifd == NULL);
 	WARN_ON(caifd == NULL);
-	if (caifd == NULL)
+	if (!caifd) {
+		rcu_read_unlock();
 		return;
 		return;
+	}
 
 
 	caifd_hold(caifd);
 	caifd_hold(caifd);
 	rcu_read_unlock();
 	rcu_read_unlock();