瀏覽代碼

spi/topcliff-pch: Fix device remove function

The call sequence spi_alloc_master/spi_register_master/spi_unregister_master
is complete; it reduces the device reference count to zero, which results in
device memory being freed. An extra call to spi_master_put is unnecessary
and results in an access to free memory. Drop it.

Also, the device subsystem resets device driver data to NULL after the call to
the remove function returns, so there is no need to do it here.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Guenter Roeck 13 年之前
父節點
當前提交
63002e84a8
共有 1 個文件被更改,包括 0 次插入2 次删除
  1. 0 2
      drivers/spi/spi-topcliff-pch.c

+ 0 - 2
drivers/spi/spi-topcliff-pch.c

@@ -1536,8 +1536,6 @@ static int __devexit pch_spi_pd_remove(struct platform_device *plat_dev)
 
 
 	pci_iounmap(board_dat->pdev, data->io_remap_addr);
 	pci_iounmap(board_dat->pdev, data->io_remap_addr);
 	spi_unregister_master(data->master);
 	spi_unregister_master(data->master);
-	spi_master_put(data->master);
-	platform_set_drvdata(plat_dev, NULL);
 
 
 	return 0;
 	return 0;
 }
 }