Эх сурвалжийг харах

bpf: offload: ignore namespace moves

We are currently destroying the device offload state when device
moves to another net namespace.  This doesn't break with current
NFP code, because offload state is not used on program removal,
but it's not correct behaviour.

Ignore the device unregister notifications on namespace move.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Jakub Kicinski 7 жил өмнө
parent
commit
62c71b45e8

+ 4 - 0
kernel/bpf/offload.c

@@ -174,6 +174,10 @@ static int bpf_offload_notification(struct notifier_block *notifier,
 
 
 	switch (event) {
 	switch (event) {
 	case NETDEV_UNREGISTER:
 	case NETDEV_UNREGISTER:
+		/* ignore namespace changes */
+		if (netdev->reg_state != NETREG_UNREGISTERING)
+			break;
+
 		list_for_each_entry_safe(offload, tmp, &bpf_prog_offload_devs,
 		list_for_each_entry_safe(offload, tmp, &bpf_prog_offload_devs,
 					 offloads) {
 					 offloads) {
 			if (offload->netdev == netdev)
 			if (offload->netdev == netdev)