Browse Source

ext4: initialize retries variable in ext4_da_write_inline_data_begin()

Variable retries is not initialized in ext4_da_write_inline_data_begin()
which can lead to nondeterministic number of retries in case we hit
ENOSPC. Initialize retries to zero as we do everywhere else.

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Fixes: bc0ca9df3b2a ("ext4: retry allocation when inline->extent conversion failed")
Cc: stable@kernel.org
Lukas Czerner 6 years ago
parent
commit
625ef8a3ac
1 changed files with 1 additions and 1 deletions
  1. 1 1
      fs/ext4/inline.c

+ 1 - 1
fs/ext4/inline.c

@@ -863,7 +863,7 @@ int ext4_da_write_inline_data_begin(struct address_space *mapping,
 	handle_t *handle;
 	handle_t *handle;
 	struct page *page;
 	struct page *page;
 	struct ext4_iloc iloc;
 	struct ext4_iloc iloc;
-	int retries;
+	int retries = 0;
 
 
 	ret = ext4_get_inode_loc(inode, &iloc);
 	ret = ext4_get_inode_loc(inode, &iloc);
 	if (ret)
 	if (ret)