Browse Source

f2fs: test before set/clear bits

If the bit is already set, we don't need to reset it, and vice versa.
Because we don't need to make the caches dirty for that.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Jaegeuk Kim 11 years ago
parent
commit
61e0f2d0a5
1 changed files with 4 additions and 2 deletions
  1. 4 2
      fs/f2fs/f2fs.h

+ 4 - 2
fs/f2fs/f2fs.h

@@ -1003,7 +1003,8 @@ enum {
 
 
 static inline void set_inode_flag(struct f2fs_inode_info *fi, int flag)
 static inline void set_inode_flag(struct f2fs_inode_info *fi, int flag)
 {
 {
-	set_bit(flag, &fi->flags);
+	if (!test_bit(flag, &fi->flags))
+		set_bit(flag, &fi->flags);
 }
 }
 
 
 static inline int is_inode_flag_set(struct f2fs_inode_info *fi, int flag)
 static inline int is_inode_flag_set(struct f2fs_inode_info *fi, int flag)
@@ -1013,7 +1014,8 @@ static inline int is_inode_flag_set(struct f2fs_inode_info *fi, int flag)
 
 
 static inline void clear_inode_flag(struct f2fs_inode_info *fi, int flag)
 static inline void clear_inode_flag(struct f2fs_inode_info *fi, int flag)
 {
 {
-	clear_bit(flag, &fi->flags);
+	if (test_bit(flag, &fi->flags))
+		clear_bit(flag, &fi->flags);
 }
 }
 
 
 static inline void set_acl_inode(struct f2fs_inode_info *fi, umode_t mode)
 static inline void set_acl_inode(struct f2fs_inode_info *fi, umode_t mode)