Эх сурвалжийг харах

net: fec: add return value check after calling .of_property_read_u32()

Add return value check after calling .of_property_read_u32() to avoid
the warning reported by coverity.

Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Fugang Duan 8 жил өмнө
parent
commit
61e04ccbcb

+ 2 - 2
drivers/net/ethernet/freescale/fec_main.c

@@ -3197,9 +3197,9 @@ static void fec_reset_phy(struct platform_device *pdev)
 	if (!np)
 	if (!np)
 		return;
 		return;
 
 
-	of_property_read_u32(np, "phy-reset-duration", &msec);
+	err = of_property_read_u32(np, "phy-reset-duration", &msec);
 	/* A sane reset duration should not be longer than 1s */
 	/* A sane reset duration should not be longer than 1s */
-	if (msec > 1000)
+	if (!err && msec > 1000)
 		msec = 1;
 		msec = 1;
 
 
 	phy_reset = of_get_named_gpio(np, "phy-reset-gpios", 0);
 	phy_reset = of_get_named_gpio(np, "phy-reset-gpios", 0);