Browse Source

cxgb4: fix memory leak on txq_info

Currently if txq_info->uldtxq cannot be allocated then
txq_info->txq is being kfree'd (which is redundant because it
is NULL) instead of txq_info. Fix this by instead kfree'ing
txq_info.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Colin Ian King 8 years ago
parent
commit
619228d86b
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c

+ 1 - 1
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c

@@ -532,7 +532,7 @@ setup_sge_txq_uld(struct adapter *adap, unsigned int uld_type,
 	txq_info->uldtxq = kcalloc(txq_info->ntxq, sizeof(struct sge_uld_txq),
 				   GFP_KERNEL);
 	if (!txq_info->uldtxq) {
-		kfree(txq_info->uldtxq);
+		kfree(txq_info);
 		return -ENOMEM;
 	}