Browse Source

media: Hexium Orion: Adjust one function call together with a variable assignment

The script "checkpatch.pl" pointed information out like the following.

ERROR: do not use assignment in if condition

Thus fix the affected source code place.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Markus Elfring 8 years ago
parent
commit
5f4d34693c
1 changed files with 3 additions and 1 deletions
  1. 3 1
      drivers/media/pci/saa7146/hexium_orion.c

+ 3 - 1
drivers/media/pci/saa7146/hexium_orion.c

@@ -266,7 +266,9 @@ static int hexium_probe(struct saa7146_dev *dev)
 
 
 	/* check if this is an old hexium Orion card by looking at
 	/* check if this is an old hexium Orion card by looking at
 	   a saa7110 at address 0x4e */
 	   a saa7110 at address 0x4e */
-	if (0 == (err = i2c_smbus_xfer(&hexium->i2c_adapter, 0x4e, 0, I2C_SMBUS_READ, 0x00, I2C_SMBUS_BYTE_DATA, &data))) {
+	err = i2c_smbus_xfer(&hexium->i2c_adapter, 0x4e, 0, I2C_SMBUS_READ,
+			     0x00, I2C_SMBUS_BYTE_DATA, &data);
+	if (err == 0) {
 		pr_info("device is a Hexium HV-PCI6/Orion (old)\n");
 		pr_info("device is a Hexium HV-PCI6/Orion (old)\n");
 		/* we store the pointer in our private data field */
 		/* we store the pointer in our private data field */
 		dev->ext_priv = hexium;
 		dev->ext_priv = hexium;