浏览代码

mtd: nand: denali: use upper/lower_32_bits() macro for clean-up

I used (uint64_t) cast to avoid "right shift count >= width of type"
warning.  <linux/kernel.h> provides nice helpers to cater to it.
The code will be cleaner, and easier to understand.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Masahiro Yamada 8 年之前
父节点
当前提交
5f2baae005
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      drivers/mtd/nand/denali.c

+ 2 - 2
drivers/mtd/nand/denali.c

@@ -469,10 +469,10 @@ static void denali_setup_dma64(struct denali_nand_info *denali,
 			  0x01002000 | (64 << 16) | (write << 8) | page_count);
 			  0x01002000 | (64 << 16) | (write << 8) | page_count);
 
 
 	/* 2. set memory low address */
 	/* 2. set memory low address */
-	denali_host_write(denali, mode, dma_addr);
+	denali_host_write(denali, mode, lower_32_bits(dma_addr));
 
 
 	/* 3. set memory high address */
 	/* 3. set memory high address */
-	denali_host_write(denali, mode, (uint64_t)dma_addr >> 32);
+	denali_host_write(denali, mode, upper_32_bits(dma_addr));
 }
 }
 
 
 static void denali_setup_dma32(struct denali_nand_info *denali,
 static void denali_setup_dma32(struct denali_nand_info *denali,