netfilter: nft_osf: check if attribute is present · 5e91c9d9cd - Gogs: Go Git Service GfA electronic

netfilter: nft_osf: check if attribute is present

If the attribute is not sent, eg. old libnftnl binary, then
tb[NFTA_OSF_TTL] is NULL and kernel crashes from the _init path.

Fixes: a218dc82f0b5 ("netfilter: nft_osf: Add ttl option support")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

Pablo Neira Ayuso 6 years ago

parent

61792b6774

commit

5e91c9d9cd

1 changed files with 1 additions and 1 deletions

Split View Show Diff Stats

						
							+ 1
							
							- 1
						
net/netfilter/nft_osf.c
							 
								View File
							
				@@ -50,7 +50,7 @@ static int nft_osf_init(const struct nft_ctx *ctx,
			
				 	int err;
			
				 	u8 ttl;
			
				-	if (nla_get_u8(tb[NFTA_OSF_TTL])) {
			
				+	if (tb[NFTA_OSF_TTL]) {
			
				 		ttl = nla_get_u8(tb[NFTA_OSF_TTL]);
			
				 		if (ttl > 2)
			
				 			return -EINVAL;