瀏覽代碼

usb: gadget: udc: clean up a printk

We already know what "value" is, so there is no need to check.  It
puzzles static checkers to have the unneeded condition.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Dan Carpenter 10 年之前
父節點
當前提交
5e841efef7
共有 1 個文件被更改,包括 4 次插入4 次删除
  1. 4 4
      drivers/usb/gadget/udc/bdc/bdc_ep.c

+ 4 - 4
drivers/usb/gadget/udc/bdc/bdc_ep.c

@@ -881,8 +881,8 @@ static int ep_set_halt(struct bdc_ep *ep, u32 value)
 
 
 		ret = bdc_ep_set_stall(bdc, ep->ep_num);
 		ret = bdc_ep_set_stall(bdc, ep->ep_num);
 		if (ret)
 		if (ret)
-			dev_err(bdc->dev, "failed to %s STALL on %s\n",
-				value ? "set" : "clear", ep->name);
+			dev_err(bdc->dev, "failed to set STALL on %s\n",
+				ep->name);
 		else
 		else
 			ep->flags |= BDC_EP_STALL;
 			ep->flags |= BDC_EP_STALL;
 	} else {
 	} else {
@@ -890,8 +890,8 @@ static int ep_set_halt(struct bdc_ep *ep, u32 value)
 		dev_dbg(bdc->dev, "Before Clear\n");
 		dev_dbg(bdc->dev, "Before Clear\n");
 		ret = bdc_ep_clear_stall(bdc, ep->ep_num);
 		ret = bdc_ep_clear_stall(bdc, ep->ep_num);
 		if (ret)
 		if (ret)
-			dev_err(bdc->dev, "failed to %s STALL on %s\n",
-				value ? "set" : "clear", ep->name);
+			dev_err(bdc->dev, "failed to clear STALL on %s\n",
+				ep->name);
 		else
 		else
 			ep->flags &= ~BDC_EP_STALL;
 			ep->flags &= ~BDC_EP_STALL;
 		dev_dbg(bdc->dev, "After  Clear\n");
 		dev_dbg(bdc->dev, "After  Clear\n");