Эх сурвалжийг харах

serial: mxs-auart: Disable clock on error path

We should disable the previously acquired clock when enabling s->clk
fails.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Estevam 9 жил өмнө
parent
commit
5d7519dfc9

+ 5 - 1
drivers/tty/serial/mxs-auart.c

@@ -1543,10 +1543,14 @@ static int mxs_get_clks(struct mxs_auart_port *s,
 	err = clk_prepare_enable(s->clk);
 	err = clk_prepare_enable(s->clk);
 	if (err) {
 	if (err) {
 		dev_err(s->dev, "Failed to enable clk!\n");
 		dev_err(s->dev, "Failed to enable clk!\n");
-		return err;
+		goto disable_clk_ahb;
 	}
 	}
 
 
 	return 0;
 	return 0;
+
+disable_clk_ahb:
+	clk_disable_unprepare(s->clk_ahb);
+	return err;
 }
 }
 
 
 /*
 /*