Эх сурвалжийг харах

Staging: lustre: osc: remove unneeded null test before free

Kfree can cope with a null argument, so drop null tests.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ expression ptr; @@

- if (ptr != NULL)
  kfree(ptr);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Julia Lawall 10 жил өмнө
parent
commit
59e267c07b

+ 1 - 2
drivers/staging/lustre/lustre/osc/osc_request.c

@@ -2064,8 +2064,7 @@ out:
 
 
 		if (oa)
 		if (oa)
 			OBDO_FREE(oa);
 			OBDO_FREE(oa);
-		if (pga)
-			kfree(pga);
+		kfree(pga);
 		/* this should happen rarely and is pretty bad, it makes the
 		/* this should happen rarely and is pretty bad, it makes the
 		 * pending list not follow the dirty order */
 		 * pending list not follow the dirty order */
 		while (!list_empty(ext_list)) {
 		while (!list_empty(ext_list)) {