Преглед изворни кода

KVM: Fix bogus failure in kvm.ko module initialization

A bogus 'return r' can cause an otherwise successful module load to fail.
This both denies users the use of kvm, and it also denies them the use of
their machine, as it leaves a filesystem registered with its callbacks
pointing into now-freed module memory.

Fix by returning a zero like a good module.

Thanks to Richard Lucassen <mailinglists@lucassen.org> (?) for reporting
the problem and for providing access to a machine which exhibited it.

Signed-off-by: Avi Kivity <avi@qumranet.com>
Avi Kivity пре 19 година
родитељ
комит
58e690e6fd
1 измењених фајлова са 1 додато и 1 уклоњено
  1. 1 1
      drivers/kvm/kvm_main.c

+ 1 - 1
drivers/kvm/kvm_main.c

@@ -2540,7 +2540,7 @@ static __init int kvm_init(void)
 	bad_page_address = page_to_pfn(bad_page) << PAGE_SHIFT;
 	bad_page_address = page_to_pfn(bad_page) << PAGE_SHIFT;
 	memset(__va(bad_page_address), 0, PAGE_SIZE);
 	memset(__va(bad_page_address), 0, PAGE_SIZE);
 
 
-	return r;
+	return 0;
 
 
 out:
 out:
 	kvm_exit_debug();
 	kvm_exit_debug();