瀏覽代碼

pktcdvd: fix setting of 'ret' error return for a few cases

We initialize it to -ENOMEM, but then later overwrite it. After
overwriting, we don't set it again for two later failure cases.

Reported-by: Jason Wood <jasonwood2031@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe 7 年之前
父節點
當前提交
566484a9e8
共有 1 個文件被更改,包括 1 次插入0 次删除
  1. 1 0
      drivers/block/pktcdvd.c

+ 1 - 0
drivers/block/pktcdvd.c

@@ -2740,6 +2740,7 @@ static int pkt_setup_dev(dev_t dev, dev_t* pkt_dev)
 	pd->write_congestion_on  = write_congestion_on;
 	pd->write_congestion_off = write_congestion_off;
 
+	ret = -ENOMEM;
 	disk = alloc_disk(1);
 	if (!disk)
 		goto out_mem;