Преглед на файлове

gpu: ion: dereferencing an ERR_PTR

We dereference "heap->task" before checking if it's an ERR_PTR.

Fixes: ea313b5f88ed ('gpu: ion: Also shrink memory cached in the deferred free list')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter преди 12 години
родител
ревизия
54de9af9f0
променени са 1 файла, в които са добавени 1 реда и са изтрити 1 реда
  1. 1 1
      drivers/staging/android/ion/ion_heap.c

+ 1 - 1
drivers/staging/android/ion/ion_heap.c

@@ -243,12 +243,12 @@ int ion_heap_init_deferred_free(struct ion_heap *heap)
 	init_waitqueue_head(&heap->waitqueue);
 	init_waitqueue_head(&heap->waitqueue);
 	heap->task = kthread_run(ion_heap_deferred_free, heap,
 	heap->task = kthread_run(ion_heap_deferred_free, heap,
 				 "%s", heap->name);
 				 "%s", heap->name);
-	sched_setscheduler(heap->task, SCHED_IDLE, &param);
 	if (IS_ERR(heap->task)) {
 	if (IS_ERR(heap->task)) {
 		pr_err("%s: creating thread for deferred free failed\n",
 		pr_err("%s: creating thread for deferred free failed\n",
 		       __func__);
 		       __func__);
 		return PTR_RET(heap->task);
 		return PTR_RET(heap->task);
 	}
 	}
+	sched_setscheduler(heap->task, SCHED_IDLE, &param);
 	return 0;
 	return 0;
 }
 }