Browse Source

qed: signedness bug in qed_dcbx_process_tlv()

"priority" needs to be signed for the error handling to work.

Fixes: 39651abd2814 ('qed: add support for dcbx.')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Dan Carpenter 9 years ago
parent
commit
54b9430f04
1 changed files with 2 additions and 1 deletions
  1. 2 1
      drivers/net/ethernet/qlogic/qed/qed_dcbx.c

+ 2 - 1
drivers/net/ethernet/qlogic/qed/qed_dcbx.c

@@ -192,9 +192,10 @@ qed_dcbx_process_tlv(struct qed_hwfn *p_hwfn,
 		     struct dcbx_app_priority_entry *p_tbl,
 		     struct dcbx_app_priority_entry *p_tbl,
 		     u32 pri_tc_tbl, int count, bool dcbx_enabled)
 		     u32 pri_tc_tbl, int count, bool dcbx_enabled)
 {
 {
-	u8 tc, priority, priority_map;
+	u8 tc, priority_map;
 	enum dcbx_protocol_type type;
 	enum dcbx_protocol_type type;
 	u16 protocol_id;
 	u16 protocol_id;
+	int priority;
 	bool enable;
 	bool enable;
 	int i;
 	int i;