Browse Source

fou: avoid missing unlock in failure path

Fixes: 7a6c8c34e5b7 ("fou: implement FOU_CMD_GET")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
WANG Cong 10 years ago
parent
commit
540207ae69
1 changed files with 1 additions and 2 deletions
  1. 1 2
      net/ipv4/fou.c

+ 1 - 2
net/ipv4/fou.c

@@ -711,11 +711,10 @@ static int fou_nl_dump(struct sk_buff *skb, struct netlink_callback *cb)
 				    cb->nlh->nlmsg_seq, NLM_F_MULTI,
 				    cb->nlh->nlmsg_seq, NLM_F_MULTI,
 				    skb, FOU_CMD_GET);
 				    skb, FOU_CMD_GET);
 		if (ret)
 		if (ret)
-			goto done;
+			break;
 	}
 	}
 	mutex_unlock(&fn->fou_lock);
 	mutex_unlock(&fn->fou_lock);
 
 
-done:
 	cb->args[0] = idx;
 	cb->args[0] = idx;
 	return skb->len;
 	return skb->len;
 }
 }