Jelajahi Sumber

ath6kl: fix firmware version assignment

Improper use of strlcpy caused garbage to be appended to the
firmware version string.  Fix this by paying attention to the
ie_lenth.

Signed-off-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Ben Greear 9 tahun lalu
induk
melakukan
53cc3291bc
1 mengubah file dengan 1 tambahan dan 1 penghapusan
  1. 1 1
      drivers/net/wireless/ath/ath6kl/init.c

+ 1 - 1
drivers/net/wireless/ath/ath6kl/init.c

@@ -994,7 +994,7 @@ static int ath6kl_fetch_fw_apin(struct ath6kl *ar, const char *name)
 		switch (ie_id) {
 		case ATH6KL_FW_IE_FW_VERSION:
 			strlcpy(ar->wiphy->fw_version, data,
-				sizeof(ar->wiphy->fw_version));
+				min(sizeof(ar->wiphy->fw_version), ie_len+1));
 
 			ath6kl_dbg(ATH6KL_DBG_BOOT,
 				   "found fw version %s\n",