Преглед изворни кода

workqueue: use put_device() instead of kfree()

Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized in this function instead.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Arvind Yadav пре 7 година
родитељ
комит
537f4146c5
1 измењених фајлова са 1 додато и 1 уклоњено
  1. 1 1
      kernel/workqueue.c

+ 1 - 1
kernel/workqueue.c

@@ -5337,7 +5337,7 @@ int workqueue_sysfs_register(struct workqueue_struct *wq)
 
 
 	ret = device_register(&wq_dev->dev);
 	ret = device_register(&wq_dev->dev);
 	if (ret) {
 	if (ret) {
-		kfree(wq_dev);
+		put_device(&wq_dev->dev);
 		wq->wq_dev = NULL;
 		wq->wq_dev = NULL;
 		return ret;
 		return ret;
 	}
 	}