Browse Source

sparc64: fix incorrect sign extension in sys_sparc64_personality

The value returned by sys_personality has type "long int".
It is saved to a variable of type "int", which is not a problem
yet because the type of task_struct->pesonality is "unsigned int".
The problem is the sign extension from "int" to "long int"
that happens on return from sys_sparc64_personality.

For example, a userspace call personality((unsigned) -EINVAL) will
result to any subsequent personality call, including absolutely
harmless read-only personality(0xffffffff) call, failing with
errno set to EINVAL.

Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Dmitry V. Levin 9 years ago
parent
commit
525fd5a94e
1 changed files with 1 additions and 1 deletions
  1. 1 1
      arch/sparc/kernel/sys_sparc_64.c

+ 1 - 1
arch/sparc/kernel/sys_sparc_64.c

@@ -413,7 +413,7 @@ out:
 
 
 SYSCALL_DEFINE1(sparc64_personality, unsigned long, personality)
 SYSCALL_DEFINE1(sparc64_personality, unsigned long, personality)
 {
 {
-	int ret;
+	long ret;
 
 
 	if (personality(current->personality) == PER_LINUX32 &&
 	if (personality(current->personality) == PER_LINUX32 &&
 	    personality(personality) == PER_LINUX)
 	    personality(personality) == PER_LINUX)