Explorar o código

net/mlx4_core: Return the error value in case of command initialization failure

If mlx4_cmd_init() failed, the init_one function returned
success, although no resources were opened.

Signed-off-by: Eugenia Emantayev <eugenia@mellanox.com>
Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Eugenia Emantayev %!s(int64=13) %!d(string=hai) anos
pai
achega
521130d11f
Modificáronse 1 ficheiros con 2 adicións e 1 borrados
  1. 2 1
      drivers/net/ethernet/mellanox/mlx4/main.c

+ 2 - 1
drivers/net/ethernet/mellanox/mlx4/main.c

@@ -1997,7 +1997,8 @@ static int __mlx4_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
 	}
 	}
 
 
 slave_start:
 slave_start:
-	if (mlx4_cmd_init(dev)) {
+	err = mlx4_cmd_init(dev);
+	if (err) {
 		mlx4_err(dev, "Failed to init command interface, aborting.\n");
 		mlx4_err(dev, "Failed to init command interface, aborting.\n");
 		goto err_sriov;
 		goto err_sriov;
 	}
 	}