فهرست منبع

l2tp: avoid use-after-free caused by l2tp_ip_backlog_recv

l2tp_ip_backlog_recv may not return -1 if the packet gets dropped.
The return value is passed up to ip_local_deliver_finish, which treats
negative values as an IP protocol number for resubmission.

Signed-off-by: Paul Hüber <phueber@kernsp.in>
Signed-off-by: David S. Miller <davem@davemloft.net>
Paul Hüber 8 سال پیش
والد
کامیت
51fb60eb16
1فایلهای تغییر یافته به همراه1 افزوده شده و 1 حذف شده
  1. 1 1
      net/l2tp/l2tp_ip.c

+ 1 - 1
net/l2tp/l2tp_ip.c

@@ -388,7 +388,7 @@ static int l2tp_ip_backlog_recv(struct sock *sk, struct sk_buff *skb)
 drop:
 drop:
 	IP_INC_STATS(sock_net(sk), IPSTATS_MIB_INDISCARDS);
 	IP_INC_STATS(sock_net(sk), IPSTATS_MIB_INDISCARDS);
 	kfree_skb(skb);
 	kfree_skb(skb);
-	return -1;
+	return 0;
 }
 }
 
 
 /* Userspace will call sendmsg() on the tunnel socket to send L2TP
 /* Userspace will call sendmsg() on the tunnel socket to send L2TP