Browse Source

pinctrl: pinctrl-imx: don't use invalid value of conf_reg

The right check for conf_reg to be invalid it testing against -1 not 0
as is done in the rest of the driver.

This fixes an oops that can be triggered by:

	cat /sys/kernel/debug/pinctrl/43fac000.iomuxc/*

Fixes: ae75ff814538 ("pinctrl: pinctrl-imx: add imx pinctrl core driver")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Uwe Kleine-König 10 years ago
parent
commit
4ff0f034e9
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/pinctrl/freescale/pinctrl-imx.c

+ 1 - 1
drivers/pinctrl/freescale/pinctrl-imx.c

@@ -437,7 +437,7 @@ static void imx_pinconf_dbg_show(struct pinctrl_dev *pctldev,
 	const struct imx_pin_reg *pin_reg = &info->pin_regs[pin_id];
 	const struct imx_pin_reg *pin_reg = &info->pin_regs[pin_id];
 	unsigned long config;
 	unsigned long config;
 
 
-	if (!pin_reg || !pin_reg->conf_reg) {
+	if (!pin_reg || pin_reg->conf_reg == -1) {
 		seq_printf(s, "N/A");
 		seq_printf(s, "N/A");
 		return;
 		return;
 	}
 	}