Browse Source

binder: fix incorrect cmd to binder_stat_br

commit 26549d177410 ("binder: guarantee txn complete / errors delivered
in-order") passed the locally declared and undefined cmd
to binder_stat_br() which results in a bogus cmd field in a trace
event and BR stats are incremented incorrectly.

Change to use e->cmd which has been initialized.

Signed-off-by: Todd Kjos <tkjos@google.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 26549d177410 ("binder: guarantee txn complete / errors delivered in-order")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Todd Kjos 8 years ago
parent
commit
4f9adc8f91
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/android/binder.c

+ 1 - 1
drivers/android/binder.c

@@ -3619,7 +3619,7 @@ retry:
 			e->cmd = BR_OK;
 			e->cmd = BR_OK;
 			ptr += sizeof(uint32_t);
 			ptr += sizeof(uint32_t);
 
 
-			binder_stat_br(proc, thread, cmd);
+			binder_stat_br(proc, thread, e->cmd);
 		} break;
 		} break;
 		case BINDER_WORK_TRANSACTION_COMPLETE: {
 		case BINDER_WORK_TRANSACTION_COMPLETE: {
 			binder_inner_proc_unlock(proc);
 			binder_inner_proc_unlock(proc);