Browse Source

i2c: rcar: enable RuntimePM before registering to the core

The core may register clients attached to this master which may use
funtionality from the master. So, RuntimePM must be enabled before, otherwise
this will fail. While here, move drvdata, too.

Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@kernel.org
Wolfram Sang 9 years ago
parent
commit
4f7effddf4
1 changed files with 4 additions and 3 deletions
  1. 4 3
      drivers/i2c/busses/i2c-rcar.c

+ 4 - 3
drivers/i2c/busses/i2c-rcar.c

@@ -690,15 +690,16 @@ static int rcar_i2c_probe(struct platform_device *pdev)
 		return ret;
 		return ret;
 	}
 	}
 
 
+	pm_runtime_enable(dev);
+	platform_set_drvdata(pdev, priv);
+
 	ret = i2c_add_numbered_adapter(adap);
 	ret = i2c_add_numbered_adapter(adap);
 	if (ret < 0) {
 	if (ret < 0) {
 		dev_err(dev, "reg adap failed: %d\n", ret);
 		dev_err(dev, "reg adap failed: %d\n", ret);
+		pm_runtime_disable(dev);
 		return ret;
 		return ret;
 	}
 	}
 
 
-	pm_runtime_enable(dev);
-	platform_set_drvdata(pdev, priv);
-
 	dev_info(dev, "probed\n");
 	dev_info(dev, "probed\n");
 
 
 	return 0;
 	return 0;