Эх сурвалжийг харах

drm/amd/display: release spinlock before committing updates to stream

Currently, amdgpu_do_flip() spinlocks crtc->dev->event_lock and
releases it only after committing updates to the stream.

dc_commit_updates_for_stream() should be moved out of
spinlock for the below reasons:

1. event_lock is supposed to protect access to acrct->pflip_status _only_
2. dc_commit_updates_for_stream() has potential sleep's
   and also its not appropriate to be  in an atomic state
   for such long sequences of code.

Signed-off-by: Shirish S <shirish.s@amd.com>
Suggested-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
Shirish S 7 жил өмнө
parent
commit
4de9f38bb2

+ 2 - 4
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

@@ -3928,10 +3928,11 @@ static void amdgpu_dm_do_flip(struct drm_crtc *crtc,
 	if (acrtc->base.state->event)
 	if (acrtc->base.state->event)
 		prepare_flip_isr(acrtc);
 		prepare_flip_isr(acrtc);
 
 
+	spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
+
 	surface_updates->surface = dc_stream_get_status(acrtc_state->stream)->plane_states[0];
 	surface_updates->surface = dc_stream_get_status(acrtc_state->stream)->plane_states[0];
 	surface_updates->flip_addr = &addr;
 	surface_updates->flip_addr = &addr;
 
 
-
 	dc_commit_updates_for_stream(adev->dm.dc,
 	dc_commit_updates_for_stream(adev->dm.dc,
 					     surface_updates,
 					     surface_updates,
 					     1,
 					     1,
@@ -3944,9 +3945,6 @@ static void amdgpu_dm_do_flip(struct drm_crtc *crtc,
 			 __func__,
 			 __func__,
 			 addr.address.grph.addr.high_part,
 			 addr.address.grph.addr.high_part,
 			 addr.address.grph.addr.low_part);
 			 addr.address.grph.addr.low_part);
-
-
-	spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
 }
 }
 
 
 /*
 /*