Browse Source

powerpc/fsl: fsl_soc: delete unneeded test before of_node_put

Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

-if (e)
   of_node_put(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Julia Lawall 11 years ago
parent
commit
4cdd641ddd
1 changed files with 1 additions and 2 deletions
  1. 1 2
      arch/powerpc/sysdev/fsl_soc.c

+ 1 - 2
arch/powerpc/sysdev/fsl_soc.c

@@ -197,8 +197,7 @@ static int __init setup_rstcr(void)
 	if (!rstcr && ppc_md.restart == fsl_rstcr_restart)
 	if (!rstcr && ppc_md.restart == fsl_rstcr_restart)
 		printk(KERN_ERR "No RSTCR register, warm reboot won't work\n");
 		printk(KERN_ERR "No RSTCR register, warm reboot won't work\n");
 
 
-	if (np)
-		of_node_put(np);
+	of_node_put(np);
 
 
 	return 0;
 	return 0;
 }
 }