Selaa lähdekoodia

usb: musb: fix DMA for host mode

Commit ac33cdb16681 ("usb: musb: Remove ifdefs for musb_host_rx in
musb_host.c part5") introduces a problem setting DMA host mode.

The musb_advance_schedule() is called immediately after receiving an
endpoint RX interrupt without waiting for the DMA transfer to complete.

As a consequence when the dma complete interrupt arrives the in_qh
member of hw_ep is already null an the musb_host_rx() exits on !urb
error case. Fix the done condition that advances the musb schedule.

Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
Tested-by: Ladislav Michl <ladis@linux-mips.org>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Cristian Birsan 9 vuotta sitten
vanhempi
commit
4c2ba0c673
1 muutettua tiedostoa jossa 2 lisäystä ja 4 poistoa
  1. 2 4
      drivers/usb/musb/musb_host.c

+ 2 - 4
drivers/usb/musb/musb_host.c

@@ -2003,10 +2003,8 @@ void musb_host_rx(struct musb *musb, u8 epnum)
 				qh->offset,
 				qh->offset,
 				urb->transfer_buffer_length);
 				urb->transfer_buffer_length);
 
 
-			done = musb_rx_dma_in_inventra_cppi41(c, hw_ep, qh,
-							      urb, xfer_len,
-							      iso_err);
-			if (done)
+			if (musb_rx_dma_in_inventra_cppi41(c, hw_ep, qh, urb,
+							   xfer_len, iso_err))
 				goto finish;
 				goto finish;
 			else
 			else
 				dev_err(musb->controller, "error: rx_dma failed\n");
 				dev_err(musb->controller, "error: rx_dma failed\n");