Quellcode durchsuchen

USB: mon_stat.c: move assignment out of if () block

We should not be doing assignments within an if () block
so fix up the code to not do this.

change was created using Coccinelle.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Felipe Balbi <balbi@ti.com>
Greg Kroah-Hartman vor 10 Jahren
Ursprung
Commit
4c08ccf0dc
1 geänderte Dateien mit 2 neuen und 1 gelöschten Zeilen
  1. 2 1
      drivers/usb/mon/mon_stat.c

+ 2 - 1
drivers/usb/mon/mon_stat.c

@@ -28,7 +28,8 @@ static int mon_stat_open(struct inode *inode, struct file *file)
 	struct mon_bus *mbus;
 	struct mon_bus *mbus;
 	struct snap *sp;
 	struct snap *sp;
 
 
-	if ((sp = kmalloc(sizeof(struct snap), GFP_KERNEL)) == NULL)
+	sp = kmalloc(sizeof(struct snap), GFP_KERNEL);
+	if (sp == NULL)
 		return -ENOMEM;
 		return -ENOMEM;
 
 
 	mbus = inode->i_private;
 	mbus = inode->i_private;