Browse Source

fm10k: remove unnecessary else block from if statements with return

Improve code style by removing the unnecessary else block of an if
statement which immediately returns.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Jacob Keller 9 years ago
parent
commit
4ab0f79bf3
1 changed files with 6 additions and 6 deletions
  1. 6 6
      drivers/net/ethernet/intel/fm10k/fm10k_pf.c

+ 6 - 6
drivers/net/ethernet/intel/fm10k/fm10k_pf.c

@@ -1232,8 +1232,8 @@ s32 fm10k_iov_msg_mac_vlan_pf(struct fm10k_hw *hw, u32 **results,
 		err = fm10k_iov_select_vid(vf_info, (u16)vid);
 		err = fm10k_iov_select_vid(vf_info, (u16)vid);
 		if (err < 0)
 		if (err < 0)
 			return err;
 			return err;
-		else
-			vid = err;
+
+		vid = err;
 
 
 		/* update VSI info for VF in regards to VLAN table */
 		/* update VSI info for VF in regards to VLAN table */
 		err = hw->mac.ops.update_vlan(hw, vid, vf_info->vsi, set);
 		err = hw->mac.ops.update_vlan(hw, vid, vf_info->vsi, set);
@@ -1258,8 +1258,8 @@ s32 fm10k_iov_msg_mac_vlan_pf(struct fm10k_hw *hw, u32 **results,
 		err = fm10k_iov_select_vid(vf_info, vlan);
 		err = fm10k_iov_select_vid(vf_info, vlan);
 		if (err < 0)
 		if (err < 0)
 			return err;
 			return err;
-		else
-			vlan = (u16)err;
+
+		vlan = (u16)err;
 
 
 		/* notify switch of request for new unicast address */
 		/* notify switch of request for new unicast address */
 		err = hw->mac.ops.update_uc_addr(hw, vf_info->glort,
 		err = hw->mac.ops.update_uc_addr(hw, vf_info->glort,
@@ -1284,8 +1284,8 @@ s32 fm10k_iov_msg_mac_vlan_pf(struct fm10k_hw *hw, u32 **results,
 		err = fm10k_iov_select_vid(vf_info, vlan);
 		err = fm10k_iov_select_vid(vf_info, vlan);
 		if (err < 0)
 		if (err < 0)
 			return err;
 			return err;
-		else
-			vlan = (u16)err;
+
+		vlan = (u16)err;
 
 
 		/* notify switch of request for new multicast address */
 		/* notify switch of request for new multicast address */
 		err = hw->mac.ops.update_mc_addr(hw, vf_info->glort,
 		err = hw->mac.ops.update_mc_addr(hw, vf_info->glort,