Эх сурвалжийг харах

leds: tca6507: silence an uninitialized variable warning

If choose_times() returns -EINVAL that means "c1" and "c2" haven't been
initialized.  I've added a check for that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Dan Carpenter 9 жил өмнө
parent
commit
4a91c45ea5

+ 2 - 0
drivers/leds/leds-tca6507.c

@@ -327,6 +327,8 @@ static void set_times(struct tca6507_chip *tca, int bank)
 	int result;
 	int result;
 
 
 	result = choose_times(tca->bank[bank].ontime, &c1, &c2);
 	result = choose_times(tca->bank[bank].ontime, &c1, &c2);
+	if (result < 0)
+		return;
 	dev_dbg(&tca->client->dev,
 	dev_dbg(&tca->client->dev,
 		"Chose on  times %d(%d) %d(%d) for %dms\n",
 		"Chose on  times %d(%d) %d(%d) for %dms\n",
 		c1, time_codes[c1],
 		c1, time_codes[c1],