Browse Source

staging: wilc1000: use memdup_user

This patch replaces the kmalloc followed by copy_from_user by the
wrapper routine memdup_user.

Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hari Prasath Gujulan Elango 10 years ago
parent
commit
4a01f1c3ab
1 changed files with 3 additions and 9 deletions
  1. 3 9
      drivers/staging/wilc1000/linux_wlan.c

+ 3 - 9
drivers/staging/wilc1000/linux_wlan.c

@@ -2459,16 +2459,10 @@ int mac_ioctl(struct net_device *ndev, struct ifreq *req, int cmd)
 		size = wrq->u.data.length;
 
 		if (size && wrq->u.data.pointer) {
-			buff = kmalloc(size, GFP_KERNEL);
-			if (!buff) {
-				s32Error = -ENOMEM;
-				goto done;
-			}
 
-			if (copy_from_user
-				    (buff, wrq->u.data.pointer,
-				    wrq->u.data.length)) {
-				s32Error = -EFAULT;
+			buff = memdup_user(wrq->u.data.pointer, wrq->u.data.length);
+			if (IS_ERR(buff)) {
+				s32Error = PTR_ERR(buff);
 				goto done;
 			}