Browse Source

tty-hvsi_lib: Deletion of an unnecessary check before the function call "tty_kref_put"

The tty_kref_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Markus Elfring 10 years ago
parent
commit
48f5cde566
1 changed files with 1 additions and 2 deletions
  1. 1 2
      drivers/tty/hvc/hvsi_lib.c

+ 1 - 2
drivers/tty/hvc/hvsi_lib.c

@@ -405,8 +405,7 @@ void hvsilib_close(struct hvsi_priv *pv, struct hvc_struct *hp)
 		hvsi_send_close(pv);
 		hvsi_send_close(pv);
 	}
 	}
 
 
-	if (pv->tty)
-		tty_kref_put(pv->tty);
+	tty_kref_put(pv->tty);
 	pv->tty = NULL;
 	pv->tty = NULL;
 }
 }