Browse Source

IB/hfi1: Return actual error value from program_rcvarray()

A failure of program_rcvarray() is treated inconsistently by the
calling function.  In one case the error is returned, in a second
case, the error is overwritten with EFAULT.  In both cases the
code path is doing the same thing, allocating memory for groups,
so it should be consistent.

Make the error path consistent and return the error generated by
program_rcvarray().

Reviewed-by: Harish Chegondi <harish.chegondi@intel.com>
Fixes: 7e7a436ecb6e ("staging/hfi1: Add TID entry program function body")
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Michael J. Ruhl 7 years ago
parent
commit
48e0a6559d
1 changed files with 0 additions and 1 deletions
  1. 0 1
      drivers/infiniband/hw/hfi1/user_exp_rcv.c

+ 0 - 1
drivers/infiniband/hw/hfi1/user_exp_rcv.c

@@ -437,7 +437,6 @@ int hfi1_user_exp_rcv_setup(struct hfi1_filedata *fd,
 				hfi1_cdbg(TID,
 				hfi1_cdbg(TID,
 					  "Failed to program RcvArray entries %d",
 					  "Failed to program RcvArray entries %d",
 					  ret);
 					  ret);
-				ret = -EFAULT;
 				goto unlock;
 				goto unlock;
 			} else if (ret > 0) {
 			} else if (ret > 0) {
 				if (grp->used == grp->size)
 				if (grp->used == grp->size)