Browse Source

pinctrl: qcom: Clear all function selection bits

The function selection bitfield is not always 3 bits wide.
Sometimes it is 4 bits wide. Let's use the npins struct member to
determine how many bits wide the function selection bitfield is
so we clear the correct amount of bits in the register while
remuxing the pins.

Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Stephen Boyd 9 years ago
parent
commit
47a01ee9a6
1 changed files with 4 additions and 2 deletions
  1. 4 2
      drivers/pinctrl/qcom/pinctrl-msm.c

+ 4 - 2
drivers/pinctrl/qcom/pinctrl-msm.c

@@ -29,6 +29,7 @@
 #include <linux/spinlock.h>
 #include <linux/spinlock.h>
 #include <linux/reboot.h>
 #include <linux/reboot.h>
 #include <linux/pm.h>
 #include <linux/pm.h>
+#include <linux/log2.h>
 
 
 #include "../core.h"
 #include "../core.h"
 #include "../pinconf.h"
 #include "../pinconf.h"
@@ -138,10 +139,11 @@ static int msm_pinmux_set_mux(struct pinctrl_dev *pctldev,
 	struct msm_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
 	struct msm_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
 	const struct msm_pingroup *g;
 	const struct msm_pingroup *g;
 	unsigned long flags;
 	unsigned long flags;
-	u32 val;
+	u32 val, mask;
 	int i;
 	int i;
 
 
 	g = &pctrl->soc->groups[group];
 	g = &pctrl->soc->groups[group];
+	mask = GENMASK(g->mux_bit + order_base_2(g->nfuncs) - 1, g->mux_bit);
 
 
 	for (i = 0; i < g->nfuncs; i++) {
 	for (i = 0; i < g->nfuncs; i++) {
 		if (g->funcs[i] == function)
 		if (g->funcs[i] == function)
@@ -154,7 +156,7 @@ static int msm_pinmux_set_mux(struct pinctrl_dev *pctldev,
 	spin_lock_irqsave(&pctrl->lock, flags);
 	spin_lock_irqsave(&pctrl->lock, flags);
 
 
 	val = readl(pctrl->regs + g->ctl_reg);
 	val = readl(pctrl->regs + g->ctl_reg);
-	val &= ~(0x7 << g->mux_bit);
+	val &= mask;
 	val |= i << g->mux_bit;
 	val |= i << g->mux_bit;
 	writel(val, pctrl->regs + g->ctl_reg);
 	writel(val, pctrl->regs + g->ctl_reg);