Home Explore Help
Sign In
GfA
/
linux_kernel
5
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

IB/core: Fix bit curruption in ib_device_cap_flags structure

ib_device_cap_flags 64-bit expansion caused caps overlapping
and made consumers read wrong device capabilities. For example
IB_DEVICE_SG_GAPS_REG was falsely read by the iser driver causing
it to use a non-existing capability. This happened because signed
int becomes sign extended when converted it to u64. Fix this by
casting IB_DEVICE_ON_DEMAND_PAGING enumeration to ULL.

Fixes: f5aa9159a418 ('IB/core: Add arbitrary sg_list support')
Reported-by: Robert LeBlanc <robert@leblancnet.us>
Cc: Stable <stable@vger.kernel.org> #[v4.6+]
Acked-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Matan Barak <matanb@mellanox.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Max Gurtovoy 9 years ago
parent
8aec013afe
commit
47355b3cd7
1 changed files with 1 additions and 1 deletions
Unified View Show Diff Stats
  1. 1 1
      include/rdma/ib_verbs.h

+ 1 - 1
include/rdma/ib_verbs.h
View File 

@@ -217,7 +217,7 @@ enum ib_device_cap_flags {
 
 	IB_DEVICE_CROSS_CHANNEL		= (1 << 27),
 
 	IB_DEVICE_CROSS_CHANNEL		= (1 << 27),
 
 	IB_DEVICE_MANAGED_FLOW_STEERING		= (1 << 29),
 
 	IB_DEVICE_MANAGED_FLOW_STEERING		= (1 << 29),
 
 	IB_DEVICE_SIGNATURE_HANDOVER		= (1 << 30),
 
 	IB_DEVICE_SIGNATURE_HANDOVER		= (1 << 30),
 
-	IB_DEVICE_ON_DEMAND_PAGING		= (1 << 31),
 
+	IB_DEVICE_ON_DEMAND_PAGING		= (1ULL << 31),
 
 	IB_DEVICE_SG_GAPS_REG			= (1ULL << 32),
 
 	IB_DEVICE_SG_GAPS_REG			= (1ULL << 32),
 
 	IB_DEVICE_VIRTUAL_FUNCTION		= ((u64)1 << 33),
 
 	IB_DEVICE_VIRTUAL_FUNCTION		= ((u64)1 << 33),
 
 	IB_DEVICE_RAW_SCATTER_FCS		= ((u64)1 << 34),
 
 	IB_DEVICE_RAW_SCATTER_FCS		= ((u64)1 << 34),