Browse Source

serial: samsung: Remove useless spinlock

Spinlock taken only for dma_map_single() for TX buffer is completely
useless and doesn't protect anything, so remove it to simplify the code.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marek Szyprowski 8 years ago
parent
commit
469f813ffe
1 changed files with 0 additions and 4 deletions
  1. 0 4
      drivers/tty/serial/samsung.c

+ 0 - 4
drivers/tty/serial/samsung.c

@@ -906,13 +906,9 @@ static int s3c24xx_serial_request_dma(struct s3c24xx_uart_port *p)
 		goto err_free_rx;
 		goto err_free_rx;
 	}
 	}
 
 
-	spin_lock_irqsave(&p->port.lock, flags);
-
 	/* TX buffer */
 	/* TX buffer */
 	dma->tx_addr = dma_map_single(p->port.dev, p->port.state->xmit.buf,
 	dma->tx_addr = dma_map_single(p->port.dev, p->port.state->xmit.buf,
 				UART_XMIT_SIZE, DMA_TO_DEVICE);
 				UART_XMIT_SIZE, DMA_TO_DEVICE);
-
-	spin_unlock_irqrestore(&p->port.lock, flags);
 	if (dma_mapping_error(p->port.dev, dma->tx_addr)) {
 	if (dma_mapping_error(p->port.dev, dma->tx_addr)) {
 		ret = -EIO;
 		ret = -EIO;
 		goto err_unmap_rx;
 		goto err_unmap_rx;