浏览代码

usb: gadget: printer: eliminate pdev member of struct printer_dev

The pdev member of struct printer_dev is not used outside
printer_bind_config(), so it can just as well be a local variable there.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Andrzej Pietrasiewicz 10 年之前
父节点
当前提交
44eccced2b
共有 1 个文件被更改,包括 4 次插入4 次删除
  1. 4 4
      drivers/usb/gadget/legacy/printer.c

+ 4 - 4
drivers/usb/gadget/legacy/printer.c

@@ -83,7 +83,6 @@ struct printer_dev {
 	u8			printer_status;
 	u8			printer_status;
 	u8			reset_printer;
 	u8			reset_printer;
 	struct cdev		printer_cdev;
 	struct cdev		printer_cdev;
-	struct device		*pdev;
 	u8			printer_cdev_open;
 	u8			printer_cdev_open;
 	wait_queue_head_t	wait;
 	wait_queue_head_t	wait;
 	struct usb_function	function;
 	struct usb_function	function;
@@ -1175,6 +1174,7 @@ static int __init printer_bind_config(struct usb_configuration *c)
 {
 {
 	struct usb_gadget	*gadget = c->cdev->gadget;
 	struct usb_gadget	*gadget = c->cdev->gadget;
 	struct printer_dev	*dev;
 	struct printer_dev	*dev;
+	struct device		*pdev;
 	int			status = -ENOMEM;
 	int			status = -ENOMEM;
 	size_t			len;
 	size_t			len;
 	u32			i;
 	u32			i;
@@ -1199,11 +1199,11 @@ static int __init printer_bind_config(struct usb_configuration *c)
 		return status;
 		return status;
 
 
 	/* Setup the sysfs files for the printer gadget. */
 	/* Setup the sysfs files for the printer gadget. */
-	dev->pdev = device_create(usb_gadget_class, NULL, g_printer_devno,
+	pdev = device_create(usb_gadget_class, NULL, g_printer_devno,
 				  NULL, "g_printer");
 				  NULL, "g_printer");
-	if (IS_ERR(dev->pdev)) {
+	if (IS_ERR(pdev)) {
 		ERROR(dev, "Failed to create device: g_printer\n");
 		ERROR(dev, "Failed to create device: g_printer\n");
-		status = PTR_ERR(dev->pdev);
+		status = PTR_ERR(pdev);
 		goto fail;
 		goto fail;
 	}
 	}