Эх сурвалжийг харах

leds: sc27xx: Fix return value check in sc27xx_led_probe()

In case of error, the function dev_get_regmap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: e081c49e30ec ("leds: Add Spreadtrum SC27xx breathing light controller driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Wei Yongjun 7 жил өмнө
parent
commit
43926c2761

+ 2 - 2
drivers/leds/leds-sc27xx-bltc.c

@@ -176,8 +176,8 @@ static int sc27xx_led_probe(struct platform_device *pdev)
 	mutex_init(&priv->lock);
 	mutex_init(&priv->lock);
 	priv->base = base;
 	priv->base = base;
 	priv->regmap = dev_get_regmap(dev->parent, NULL);
 	priv->regmap = dev_get_regmap(dev->parent, NULL);
-	if (IS_ERR(priv->regmap)) {
-		err = PTR_ERR(priv->regmap);
+	if (!priv->regmap) {
+		err = -ENODEV;
 		dev_err(dev, "failed to get regmap: %d\n", err);
 		dev_err(dev, "failed to get regmap: %d\n", err);
 		return err;
 		return err;
 	}
 	}