Browse Source

ACPI / debugger: remove some unneeded conditions

"count" is unsigned so checking for less than zero here causes a static
checker warning.  And really it's better to let the access_ok() check
fail if the user passes in a NULL "buf" pointer because -EFAULT is the
correct error code.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Dan Carpenter 9 years ago
parent
commit
436db5ce0d
1 changed files with 0 additions and 4 deletions
  1. 0 4
      drivers/acpi/acpi_dbg.c

+ 0 - 4
drivers/acpi/acpi_dbg.c

@@ -610,8 +610,6 @@ static ssize_t acpi_aml_read(struct file *file, char __user *buf,
 	int ret = 0;
 	int ret = 0;
 	int size = 0;
 	int size = 0;
 
 
-	if (!buf || count < 0)
-		return -EINVAL;
 	if (!count)
 	if (!count)
 		return 0;
 		return 0;
 	if (!access_ok(VERIFY_WRITE, buf, count))
 	if (!access_ok(VERIFY_WRITE, buf, count))
@@ -681,8 +679,6 @@ static ssize_t acpi_aml_write(struct file *file, const char __user *buf,
 	int ret = 0;
 	int ret = 0;
 	int size = 0;
 	int size = 0;
 
 
-	if (!buf || count < 0)
-		return -EINVAL;
 	if (!count)
 	if (!count)
 		return 0;
 		return 0;
 	if (!access_ok(VERIFY_READ, buf, count))
 	if (!access_ok(VERIFY_READ, buf, count))