Просмотр исходного кода

pata_hpt37x: checkpatch fixes

WARNING: line over 80 characters
#70: FILE: drivers/ata/pata_hpt37x.c:850:
+		struct pci_dev *pdev_0 = pci_get_slot(pdev->bus, pdev->devfn - 1);

ERROR: else should follow close brace '}'
#78: FILE: drivers/ata/pata_hpt37x.c:858:
+	}
+	else

total: 1 errors, 1 warnings, 100 lines checked
Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Andrew Morton 18 лет назад
Родитель
Сommit
40f46f1781
1 измененных файлов с 4 добавлено и 3 удалено
  1. 4 3
      drivers/ata/pata_hpt37x.c

+ 4 - 3
drivers/ata/pata_hpt37x.c

@@ -847,15 +847,16 @@ static u32 hpt374_read_freq(struct pci_dev *pdev)
 	u32 freq;
 	u32 freq;
 	unsigned long io_base = pci_resource_start(pdev, 4);
 	unsigned long io_base = pci_resource_start(pdev, 4);
 	if (PCI_FUNC(pdev->devfn) & 1) {
 	if (PCI_FUNC(pdev->devfn) & 1) {
-		struct pci_dev *pdev_0 = pci_get_slot(pdev->bus, pdev->devfn - 1);
+		struct pci_dev *pdev_0;
+
+		pdev_0 = pci_get_slot(pdev->bus, pdev->devfn - 1);
 		/* Someone hot plugged the controller on us ? */
 		/* Someone hot plugged the controller on us ? */
 		if (pdev_0 == NULL)
 		if (pdev_0 == NULL)
 			return 0;
 			return 0;
 		io_base = pci_resource_start(pdev_0, 4);
 		io_base = pci_resource_start(pdev_0, 4);
 		freq = inl(io_base + 0x90);
 		freq = inl(io_base + 0x90);
 		pci_dev_put(pdev_0);
 		pci_dev_put(pdev_0);
-	}
-	else
+	} else
 		freq = inl(io_base + 0x90);
 		freq = inl(io_base + 0x90);
 	return freq;
 	return freq;
 }
 }